Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6718590892337917344=="
MIME-Version: 1.0
Subject: Re: Review Request 15763: Changed 'MigrateCommand' to use the global
 setting
 value of 'execute.in.sequence.hypervisor.commands'
From: "Koushik Das" <koushik.das@citrix.com>
To: "Koushik Das" <koushik.das@citrix.com>,
 "Alex Ough" <alex.ough@sungard.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 03 Dec 2013 09:01:03 -0000
Message-ID: <20131203090103.12251.8427@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
References: <20131203084422.12482.98024@reviews.apache.org>
In-Reply-To: <20131203084422.12482.98024@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============6718590892337917344==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Dec. 3, 2013, 8:44 a.m., Koushik Das wrote:
> > core/src/com/cloud/agent/api/MigrateCommand.java, line 32
> > <https://reviews.apache.org/r/15763/diff/1/?file=389559#file389559line32>
> >
> >     I see that you have tested for XS. In the mail thread people have mentioned that it should work on Vmware and KVM. Will it be possible to do a quick verification?
> >     
> >     Otherwise (except for a few minor comments) the change looks good to me.

Now that HyperV is also there can there be any issues with that?


- Koushik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15763/#review29649
-----------------------------------------------------------


On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15763/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 6:39 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
>   setup/db/db/schema-410to420.sql 522ccc4 
>   setup/db/db/schema-430to440.sql 9bb9602 
> 
> Diff: https://reviews.apache.org/r/15763/diff/
> 
> 
> Testing
> -------
> 
> Tested in the simulator mode and Xen servers.
> 
> 
> Thanks,
> 
> Alex Ough
> 
>


--===============6718590892337917344==--