cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2
Date Thu, 12 Dec 2013 05:48:29 GMT
Hi Bharat - Can you please still answer the question here ?

From: bharat kumar <bharat.kumar@citrix.com<mailto:bharat.kumar@citrix.com>>
Reply-To: Bharat Kumar <bharat.kumar@citrix.com<mailto:bharat.kumar@citrix.com>>
Date: Monday 9 December 2013 9:39 PM
To: Jayapal Reddy Uradi <jayapalreddy.uradi@citrix.com<mailto:jayapalreddy.uradi@citrix.com>>
Cc: Bharat Kumar <bharat.kumar@citrix.com<mailto:bharat.kumar@citrix.com>>, Nitin
Mehta <nitin.mehta@citrix.com<mailto:nitin.mehta@citrix.com>>, cloudstack <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>
Subject: Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16122/


On December 9th, 2013, 6:03 p.m. UTC, Nitin Mehta wrote:

plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java<https://reviews.apache.org/r/16122/diff/2/?file=395664#file395664line3007>(Diff
revision 2)

protected StartAnswer execute(StartCommand cmd) {


        3003

            return  (int) (vmSpec.getMinRam() / (1024 * 1024));


Why are you reserving if the flag is false ?

Hi Nitin,
this patch is not related to the https://reviews.apache.org/r/15349/. will upload it once
this gets shipped.


- bharat


On December 9th, 2013, 10:39 a.m. UTC, bharat kumar wrote:

Review request for cloudstack and Jayapal Reddy.
By bharat kumar.

Updated Dec. 9, 2013, 10:39 a.m.

Bugs: CLOUDSTACK-4498<https://issues.apache.org/jira/browse/CLOUDSTACK-4498>
Repository: cloudstack-git
Description

 CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu
and vmware.reserve.mem are set to false.



Testing

tested on master.


Diffs

  *   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java (eb3cb6b)
  *   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
(d306b74)
  *   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
(69f1b74)

View Diff<https://reviews.apache.org/r/16122/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message