cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Ough <alex.o...@sungard.com>
Subject Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'
Date Thu, 05 Dec 2013 15:37:11 GMT
Hi Koushik,

I followed your instructions and this is the merged commit.

https://reviews.apache.org/r/15763/diff/

Let me know if there is anything missing/incorrect.
Thanks
Alex Ough



On Wed, Dec 4, 2013 at 11:44 PM, Koushik Das <koushik.das@citrix.com> wrote:

>  Alex,
>
>  This is what you need to do.
>
>  1. Create a single commit for all the changes you have made. Currently I
> see that you have made 2 commits - your original set of changes is one
> commit and then there is the review comment related changes which is the
> other commit. You need to create a single commit out of them.
> 2. Create a patch from that commit
> 3. Update the review request with that patch.
>
>  -Koushik
>
>   On 04-Dec-2013, at 8:52 PM, Alex Ough <alex.ough@sungard.com> wrote:
>
>  Hi Koushik,
>
>  This time I reloaded only the 2 changes.
> To make it clean, I tried to remove the previous incorrect one, but I
> couldn't find how.
> So let me know if it is better to discard this review and create a new one.
>
>  Thanks
> Alex Ough
>
>
> On Wed, Dec 4, 2013 at 12:04 AM, Koushik Das <koushik.das@citrix.com>wrote:
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>>  https://reviews.apache.org/r/15763/#review29716
>> -----------------------------------------------------------
>>
>>
>> Looks like the latest patch has some issues, the diff is not showing up.
>> Also there are 2 commits in the patch file. Can you resubmit the patch with
>> only a single commit?
>>
>> - Koushik Das
>>
>>
>> On Dec. 3, 2013, 5:07 p.m., Alex Ough wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/15763/
>>  > -----------------------------------------------------------
>> >
>> > (Updated Dec. 3, 2013, 5:07 p.m.)
>> >
>> >
>> > Review request for cloudstack.
>> >
>> >
>> > Repository: cloudstack-git
>> >
>> >
>> > Description
>> > -------
>> >
>>  > When a host is switched to the 'maintenance mode', the vms in that
>> host are migrated to another available hosts. Currently, the vm migrations
>> are executed sequentially, it can take a lot of time when there are quite
>> number of vms. So I changed 'MigrateCommand' to get the value of
>> 'executeInSequence' property from the global setting value of
>> 'execute.in.sequence.hypervisor.commands' so that users can execute the
>> migrations in parallel to save time.
>> >
>> >
>>  > Diffs
>> > -----
>> >
>> >   core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c
>> >   engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f
>> >   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
>> 3a3de70
>> >   setup/db/db/schema-410to420.sql 522ccc4
>> >   setup/db/db/schema-410to420.sql 522ccc4
>> >   setup/db/db/schema-430to440.sql 9bb9602
>> >
>> > Diff: https://reviews.apache.org/r/15763/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>>  > Tested in the simulator mode and Xen servers.
>> >
>> >
>>  > Thanks,
>> >
>> > Alex Ough
>> >
>> >
>>
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message