cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sheng Yang" <sh...@yasker.org>
Subject Re: Review Request 16279: Contrail plugin fixes for db updates, adding JuniperContrailVPCRouter as a SDN Provider.
Date Mon, 30 Dec 2013 22:33:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16279/#review30981
-----------------------------------------------------------


Hi Suresh,

There is no way we can review this since it's not added as diff files. 

Please re-do the upload as diff and make sure it in the proper format that can be reviewed.
"View diff" button should be shown.

Also you'd better rebase the patch to the latest.

Thanks.

- Sheng Yang


On Dec. 15, 2013, 11:57 p.m., Suresh Balineni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16279/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 11:57 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixes for:
> 1. contrail is updating Dao tables. DB updates should be inside Trasaction start &
commit calls.
> 2. If contrail.properties file is not found set to default hostname & port id where
contrail server can be accessed from the plugin.
> 3. Add JuniperContrailVPCRouter as SDN Provider in VpcManagerImpl.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/16279/diff/
> 
> 
> Testing
> -------
> 
> Tests are done. Verified. 
> 
> 
> File Attachments
> ----------------
> 
> VPC Fix
>   https://reviews.apache.org/media/uploaded/files/2013/12/15/0f239bf5-d9ba-4cc1-b232-ee4a6ef2e0e7__vpc-fix.patch
> 
> 
> Thanks,
> 
> Suresh Balineni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message