cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16128: CLOUDSTACK-4973: Specified locale keyboard language is not showing as default in consoleView passed during deployVM.
Date Fri, 27 Dec 2013 12:55:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16128/#review30915
-----------------------------------------------------------


Commit f6b063de7994c65d307d39fe51229c671ad91f16 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f6b063d ]

CLOUDSTACK-4973: Specified keyboard language is not showing as default in consoleView passed
during deployVM.


- ASF Subversion and Git Services


On Dec. 20, 2013, 10:42 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16128/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 10:42 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUUDSTACK-4973
>     https://issues.apache.org/jira/browse/CLOUUDSTACK-4973
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4973: Specified locale keyboard language is not showing as default in consoleView
passed during deployVM.
> 
>     While deploying a VM, user passes the "keyboard" parameter to specify the
>     default language for that VM but in the consoleView, the default language
>     selected is en-us irrespective of the default language of the VM.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 
>   server/src/com/cloud/servlet/ConsoleProxyServlet.java b3415db 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
6cadeca 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
07a1b6f 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
8de4955 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java
297e711 
>   systemvm/js/ajaxviewer.js 9643204 
> 
> Diff: https://reviews.apache.org/r/16128/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message