cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Shilamkar" <gir...@clogeny.com>
Subject Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
Date Fri, 27 Dec 2013 05:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16467/#review30901
-----------------------------------------------------------

Ship it!


Committed to 4.3 and master.

- Girish Shilamkar


On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16467/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 2:06 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5638
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5638
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking
the router state.
> Sometimes, it needs more time for router to come up in running state, so modified code
to check the router state after definite time intervals, it will fail after timeout (180 Seconds
for now).
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_routers.py 5f1ebc6 
> 
> Diff: https://reviews.apache.org/r/16467/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> Test advanced zone router services ... SKIP: Skip
> Test network garbage collection ... ok
> Test router start on VM deploy ... SKIP: Skip
> Test router stop create Firewall rule ... SKIP: Skip
> Test router stop create Load balancing ... SKIP: Skip
> Test router stop create port forwarding ... SKIP: Skip
> 
> ----------------------------------------------------------------------
> Ran 6 tests in 799.271s
> 
> OK (SKIP=5)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message