cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
Date Tue, 24 Dec 2013 09:18:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 9:18 a.m.)


Review request for cloudstack and Sateesh Chodapuneedi.


Changes
-------

Modified isNetworkAWithinNetworkB to compare IP ranges.


Bugs: CLOUDSTACK-4622
    https://issues.apache.org/jira/browse/CLOUDSTACK-4622


Repository: cloudstack-git


Description
-------

Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal
or a subset of cidrB's IP range.


Diffs (updated)
-----

  utils/src/com/cloud/utils/net/NetUtils.java f6f6285 
  utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf 

Diff: https://reviews.apache.org/r/14124/diff/


Testing
-------

Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message