cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case
Date Mon, 23 Dec 2013 12:28:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/#review30812
-----------------------------------------------------------


Commit 0faf772635cbc6ca26cdb52fbbe7d008db0e2277 in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0faf772 ]

CLOUDSTACK-5518: Fixing non contiguous vlan test case


- ASF Subversion and Git Services


On Dec. 19, 2013, 3:34 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16386/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:34 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5518
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5518
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The issue in 5518 is, if newly added vlan range is getting used by other test cases,
then that range will get considered as used and we are trying to remove the unused range.
> The problem reported by Rayees is not the exact issue. I have updated the comments in
the bug accordingly.
> 
> I have changed the code in test case to minimize the time interval between adding the
new range and removing it so as to minimize the probability of it getting used by other test
cases dynamically.
> 
> Also cleaned up the imports and improved other test case.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py 5ef1ec7 
> 
> Diff: https://reviews.apache.org/r/16386/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges)
... ok
> test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges)
... ok
> test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges)
... ok
> test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges)
... ok
> test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges)
... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 304.525s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message