cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16324: CLOUDSTACK-4780: Changes related to checking snapshot on NFS server
Date Sat, 21 Dec 2013 07:11:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16324/#review30777
-----------------------------------------------------------


Commit b4c4f7cbccd590d2b2d071b036a0444d3c5f2855 in branch refs/heads/4.3 from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4c4f7c ]

Revert "CLOUDSTACK-4780: Changes related to checking snapshot on NFS server"

This reverts commit 03811c0c46a3c74f4271b08faa8ce40a4e2598f7.


- ASF Subversion and Git Services


On Dec. 17, 2013, 3:21 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16324/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 3:21 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4780
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4780
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Changes:
> 
> 1) Appended snapshot extension to the snapshot path coming from database. As discussed
with Harikrishna, Product bug (5135) is invalid, snapshot path in database won't contain the
extension of the snapshot. So changing the code so as to append the extension based on hypervisor
type.
> 
> 2) Code movement and cleanup - Moved function get_hypervisor_type from common to utils
to avoid cyclic dependency of libraries. Also, cleaned up the imports.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py f1508e1 
>   test/integration/component/test_snapshots.py d3fac42 
>   tools/marvin/marvin/integration/lib/common.py 096b073 
>   tools/marvin/marvin/integration/lib/utils.py d046235 
> 
> Diff: https://reviews.apache.org/r/16324/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on VMware. KVM should not have impact of this change as the snapshot created
on KVM was found not to have any extension.
> 
> Log:
> test_01_snapshot_root_disk (test_snapshots.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 513.783s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message