cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kishan Kavala" <Kishan.Kav...@citrix.com>
Subject Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
Date Thu, 19 Dec 2013 10:24:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30687
-----------------------------------------------------------

Ship it!


1c6b146d0421ef66be1015d9f422274cea741ce3

- Kishan Kavala


On Dec. 19, 2013, 12:26 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 12:26 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5554
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5554
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than
custom.diskoffering.size.max value 
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input
values while deploying the VM and creating volume APIs.
> 
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
> 
> 
> Diffs
> -----
> 
>   engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
1bba479 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
ebd8709 
>   server/src/com/cloud/configuration/Config.java 4da7e58 
>   server/src/com/cloud/server/ManagementServerImpl.java 8dad7ae 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java dd6358a 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439 
>   setup/db/db/schema-421to430.sql 9913b08 
> 
> Diff: https://reviews.apache.org/r/16362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message