cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request 15349: Overprivisoning changes needed
Date Mon, 16 Dec 2013 19:21:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30469
-----------------------------------------------------------


Facing the following error for diff 6

Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch

error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
patch does not apply

- Nitin Mehta


On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 12:32 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
>     https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem
is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form the global
setting when up grading. 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
71894a8 
>   setup/db/db/schema-420to421.sql fe1e0d4 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message