cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request 15902: CLOUDSTACK-4904: Unable to see a derieved template if the parent template is deleted
Date Mon, 16 Dec 2013 08:54:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15902/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 8:54 a.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Bugs: CLOUDSTACK-4904
    https://issues.apache.org/jira/browse/CLOUDSTACK-4904


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4904: Unable to see a derieved template if the parent template is deleted

Added supported for listing all templates/ISOs with showremoved = true


Diffs
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java e08923c 
  api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java c3f558b 
  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 4b34909 
  server/src/com/cloud/api/query/QueryManagerImpl.java 58df38c 
  server/src/com/cloud/api/query/dao/TemplateJoinDao.java f73f5bd 
  server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 468fb83 

Diff: https://reviews.apache.org/r/15902/diff/


Testing
-------

Tested locally.

http://localhost:8096/client/api?command=listTemplates&listAll=true&page=1&pagesize=20&templatefilter=all&_=1385533457469&showremoved=true

In the below API response "win" template is removed.

<listtemplatesresponse cloud-stack-version="4.3.0-SNAPSHOT"><count>3</count>

<template><id>f0fdb4d8-fd2f-4fc2-9590-6b45689d2a29</id>
<name>win</name>
<displaytext>win</displaytext>
</template>

<template><id>7240316e-5299-11e3-b8bd-9d3b4dd13283</id>
<name>CentOS 5.6(64-bit) no GUI (XenServer)</name>
<displaytext>CentOS 5.6(64-bit) no GUI (XenServer)</displaytext>
</template>

<template><id>723ff2c6-5299-11e3-b8bd-9d3b4dd13283</id>
<name>SystemVM Template (XenServer)</name><displaytext>SystemVM Template
(XenServer)</displaytext><ispublic>false</ispublic><created>2013-11-21T16:16:00+0530</created><isready>true</isready><passwordenabled>false</passwordenabled><format>VHD</format><isfeatured>false</isfeatured><crossZones>true</crossZones><ostypeid>72487d10-5299-11e3-b8bd-9d3b4dd13283</ostypeid><ostypename>Debian
GNU/Linux 7(32-bit)</ostypename><account>system</account><zoneid>0b267864-376e-43ab-8804-57a1a6b9a135</zoneid><zonename>xen</zonename><status>Download
Complete</status><size>2101252608</size><templatetype>SYSTEM</templatetype><hypervisor>XenServer</hypervisor><domain>ROOT</domain><domainid>730b0240-5299-11e3-b8bd-9d3b4dd13283</domainid><isextractable>false</isextractable><checksum>fb1b6e032a160d86f2c28feb5add6d83</checksum><sshkeyenabled>false</sshkeyenabled><isdynamicallyscalable>false</isdynamicallyscalable></template></listtemplatesresponse>


Thanks,

Harikrishna Patnala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message