cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16154: Fixed CLOUDSTACK-5423
Date Wed, 11 Dec 2013 06:37:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16154/#review30178
-----------------------------------------------------------


Commit c2a41b565a781eca9a2dace1459925bd150b7b7b in branch refs/heads/4.2 from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c2a41b5 ]

CLOUDSTACK-5423: Fixed 5423

Conflicts:
	tools/marvin/marvin/deployAndRun.py


- ASF Subversion and Git Services


On Dec. 10, 2013, 11:37 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16154/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5423
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5423
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. As part of recent changes to marvin, mentioned files requires some changes. 
> 2. Some cleaning is as well required for these two files. Did clean up.
> 3. Did cleanup in deployAndRun and added proper flow for ease of understanding.
> 4. Removed unwanted logging and used MarvinInit for initialization of Marvin.
> 5. Removed few unwanted loops and redundant code.
> 6. Renamed  TestCaseExecuteEngine.py -> tcExecuteEngine.py inline with other naming
convention for modules in Marvin
> 7. Added few codes and doc strings.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py f5af1fe 
>   tools/marvin/marvin/configGenerator.py 3f98aca 
>   tools/marvin/marvin/deployAndRun.py 8a758a1 
>   tools/marvin/marvin/tcExecuteEngine.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16154/diff/
> 
> 
> Testing
> -------
> 
> Tested DeployDC and Running Few test case runs with deployAndRun.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message