cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160
Date Wed, 11 Dec 2013 05:32:54 GMT


> On Dec. 4, 2013, 2:06 p.m., daan Hoogland wrote:
> > Bharat, neither version 4 nor version 3 of your patch apply to master. Also I noted
the ticket number in the commit comment changed from 5160 to 5161. Can you explain.

Hi Dann,

This change is already shipped to master, closing this review request. Also you are right
that the ticket number changed.I have linked the bugs in jira. so that one can see both the
issues for tracking purposes.

thanks,
Bharat.


- bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29732
-----------------------------------------------------------


On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> use a map to specify the custom parameters in the deployvm api Instead of one parameter
for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6fc8b54 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
>   engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
ad957d5 
>   engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 8c58227

>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4e25493 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
5dd15ce 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
71e8b7d 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message