cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2
Date Mon, 09 Dec 2013 18:03:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/#review30027
-----------------------------------------------------------



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/16122/#comment57529>

    Why are you reserving if the flag is false ?


- Nitin Mehta


On Dec. 9, 2013, 10:39 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16122/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 10:39 a.m.)
> 
> 
> Review request for cloudstack and Jayapal Reddy.
> 
> 
> Bugs: CLOUDSTACK-4498
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4498
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu
and vmware.reserve.mem are set to false.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java eb3cb6b 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
d306b74 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
69f1b74 
> 
> Diff: https://reviews.apache.org/r/16122/diff/
> 
> 
> Testing
> -------
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message