cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Nalley" <da...@gnsa.us>
Subject Re: Review Request 13072: Print agent host name in logging of agent commands
Date Wed, 04 Dec 2013 16:25:28 GMT


> On Nov. 8, 2013, 2:03 a.m., Amogh Vasekar wrote:
> > Reminder - 
> > Hi,
> > This review has been pending for long. Request the reviewer to provide comments.
> > Thanks

Appears to be committed in: 4e0e7410e99c7f57cde934af1fef9b27d0ae1e66 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review28482
-----------------------------------------------------------


On Aug. 6, 2013, 10:32 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 10:32 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3872
>     https://issues.apache.org/jira/browse/CLOUDSTACK-3872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Print agent name when logging Commands sent to VM hosts. See bug description.  I'm not
super familiar with this code, so I'd like someone to look over it and verify it's the right
thing.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/transport/Request.java b0fa4cc 
>   server/src/com/cloud/agent/manager/AgentAttache.java 1785bcf 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 
>   server/src/com/cloud/agent/manager/ClusteredAgentAttache.java 058a904 
>   server/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java 4fdb3c6 
>   server/src/com/cloud/agent/manager/ClusteredDirectAgentAttache.java 9012433 
>   server/src/com/cloud/agent/manager/ConnectedAgentAttache.java c98307b 
>   server/src/com/cloud/agent/manager/DirectAgentAttache.java 9b7d69f 
>   server/src/com/cloud/agent/manager/DummyAttache.java 14286d2 
> 
> Diff: https://reviews.apache.org/r/13072/diff/
> 
> 
> Testing
> -------
> 
> Tested on KVM zone, need help testing others.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message