Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7D6E106CE for ; Wed, 6 Nov 2013 02:26:14 +0000 (UTC) Received: (qmail 99094 invoked by uid 500); 6 Nov 2013 02:26:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 99067 invoked by uid 500); 6 Nov 2013 02:26:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 99059 invoked by uid 99); 6 Nov 2013 02:26:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 02:26:14 +0000 X-ASF-Spam-Status: No, hits=-2.8 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of min.chen@citrix.com designates 66.165.176.89 as permitted sender) Received: from [66.165.176.89] (HELO SMTP.CITRIX.COM) (66.165.176.89) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 02:26:07 +0000 X-IronPort-AV: E=Sophos;i="4.93,643,1378857600"; d="scan'208,217";a="71000415" Received: from sjcpex01cl02.citrite.net ([10.216.14.144]) by FTLPIPO01.CITRIX.COM with ESMTP/TLS/AES128-SHA; 06 Nov 2013 02:25:46 +0000 Received: from SJCPEX01CL01.citrite.net ([169.254.1.113]) by SJCPEX01CL02.citrite.net ([10.216.14.144]) with mapi id 14.02.0342.004; Tue, 5 Nov 2013 18:25:45 -0800 From: Min Chen To: Daan Hoogland CC: "dev@cloudstack.apache.org" Subject: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master Thread-Topic: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master Thread-Index: AQHO2pd+gZbv8DGMDUWCkT4MhTHz/g== Date: Wed, 6 Nov 2013 02:25:44 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.6.130613 x-originating-ip: [10.216.48.12] Content-Type: multipart/alternative; boundary="_000_CE9EE8A74DBB0minchencitrixcom_" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org --_000_CE9EE8A74DBB0minchencitrixcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3D= commit;h=3D25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced z= one setup on Master, where system vm starts failed with "NumberFormatExcept= ion", see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046.= I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289)= by reverting part of your change on HypervisorHostHelper method, but not s= ure if there is any side effect on your another functionality fixed in your= commit. Can you please review to make sure that it is ok? Thanks -min --_000_CE9EE8A74DBB0minchencitrixcom_--