Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72547100B9 for ; Wed, 27 Nov 2013 11:12:20 +0000 (UTC) Received: (qmail 86414 invoked by uid 500); 27 Nov 2013 11:12:19 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 86364 invoked by uid 500); 27 Nov 2013 11:12:19 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 86316 invoked by uid 99); 27 Nov 2013 11:12:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 11:12:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6AC111D2F78; Wed, 27 Nov 2013 11:12:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0333242286445641093==" MIME-Version: 1.0 Subject: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160 From: "bharat kumar" To: "Koushik Das" , "Jayapal Reddy" Cc: "bharat kumar" , "cloudstack" Date: Wed, 27 Nov 2013 11:12:05 -0000 Message-ID: <20131127111205.21309.90084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15875/ X-Sender: "bharat kumar" Reply-To: "bharat kumar" X-ReviewRequest-Repository: cloudstack-git --===============0333242286445641093== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/ ----------------------------------------------------------- Review request for cloudstack, Jayapal Reddy and Koushik Das. Bugs: CLOUDSTACK-5160 https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Repository: cloudstack-git Description ------- use a map to specify the custom parameters in the deployvm api Instead of one parameter for each. https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Diffs ----- api/src/com/cloud/vm/UserVmService.java 444c47a api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 Diff: https://reviews.apache.org/r/15875/diff/ Testing ------- Tested on master. Thanks, bharat kumar --===============0333242286445641093==--