Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2161341814451200787=="
MIME-Version: 1.0
Subject: Re: Review Request 15833: CLOUDSTACK-5257: Fixed Network ACL issue
 related
 to Egress traffic
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Girish Shilamkar" <girish@clogeny.com>,
 "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>
Cc: "Ashutosh Kelkar" <ashutosh@clogeny.com>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 26 Nov 2013 06:40:04 -0000
Message-ID: <20131126064004.7321.22900@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20131125143712.7321.39525@reviews.apache.org>
In-Reply-To: <20131125143712.7321.39525@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============2161341814451200787==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15833/#review29421
-----------------------------------------------------------


Commit 5b37d38ed0b156268132ade1856032102723c36e in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5b37d38 ]

CLOUDSTACK-5257: Fixed Network ACL issue related to Egress traffic

Signed-off-by: Girish Shilamkar <girish@clogeny.com>

Conflicts:
	test/integration/component/test_vpc_vms_deployment.py


- ASF Subversion and Git Services


On Nov. 25, 2013, 2:37 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15833/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 2:37 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5257
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing due to issue in ACL rule. The ACL rule was created for TCP protocol and the connection to outside world was checked using Ping protocol. In this case ICMP protocol should be used in ACL rule as Ping uses ICMP.
> Also corrected the port numbers and cleaned up code.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py baefa55 
> 
> Diff: https://reviews.apache.org/r/15833/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on XenServer advances setup.
> 
> Log:
> test_01_deploy_vms_in_network (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test deploy VMs in VPC networks ... skipped 'Skip'
> test_02_deploy_vms_delete_network (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test deploy VMs in VPC networks and delete one of the network ... skipped 'Skip'
> test_03_deploy_vms_delete_add_network (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test deploy VMs, delete one of the network and add another one ... skipped 'Skip'
> test_04_deploy_vms_delete_add_network_noLb (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test deploy VMs, delete one network without LB and add another one ... skipped 'Skip'
> test_05_create_network_max_limit (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test create networks in VPC upto maximum limit for hypervisor ... skipped 'Skip'
> test_06_delete_network_vm_running (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test delete network having running instances in VPC ... skipped 'Skip'
> test_07_delete_network_with_rules (test_vpc_vms_deployment_fixed.TestVMDeployVPC)
> Test delete network that has PF/staticNat/LB rules/Network Acl ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 5.907s
> 
> OK (skipped=7)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


--===============2161341814451200787==--