Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C0551056A for ; Mon, 25 Nov 2013 14:32:22 +0000 (UTC) Received: (qmail 6298 invoked by uid 500); 25 Nov 2013 14:32:21 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 6253 invoked by uid 500); 25 Nov 2013 14:32:20 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 6236 invoked by uid 99); 25 Nov 2013 14:32:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Nov 2013 14:32:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2DC171C3E38; Mon, 25 Nov 2013 14:32:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8787589672178449016==" MIME-Version: 1.0 Subject: Re: Review Request 15455: Fixing all Coverity bugs on file Upgrade2214to30 related to resource leak. Now the statements closed and nullified before a new assignment. From: "Wilder Rodrigues" To: "Hugo Trippaers" Cc: "Wilder Rodrigues" , "cloudstack" Date: Mon, 25 Nov 2013 14:32:09 -0000 Message-ID: <20131125143209.7321.13833@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Wilder Rodrigues" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15455/ X-Sender: "Wilder Rodrigues" References: <20131125142608.32080.96851@reviews.apache.org> In-Reply-To: <20131125142608.32080.96851@reviews.apache.org> Reply-To: "Wilder Rodrigues" X-ReviewRequest-Repository: cloudstack-git --===============8787589672178449016== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15455/ ----------------------------------------------------------- (Updated Nov. 25, 2013, 2:32 p.m.) Review request for cloudstack and Hugo Trippaers. Changes ------- Not the right way to do that. Repository: cloudstack-git Description ------- Coverity bug #1116754 Resource leak on an exceptional path. The system resource will not be reclaimed and reused, reducing the future availability of the resource. In com.?cloud.?upgrade.?dao.?Upgrade2214to30.?setupPhysicalNetworks(java.?sql.?Connection): Leak of a system resource on an exception path (probably error handling) (CWE-404) Since the file contained the same implementation all over the place - in many different methods - I already updated everything. Diffs ----- engine/schema/src/com/cloud/upgrade/dao/Upgrade2214to30.java 48b83b4 Diff: https://reviews.apache.org/r/15455/diff/ Testing ------- All tests passed during build and I also applied the patch to a different branch, based on Master, and built the project: all passed. Thanks, Wilder Rodrigues --===============8787589672178449016==--