Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1ABAE109FB for ; Sun, 17 Nov 2013 22:29:52 +0000 (UTC) Received: (qmail 75728 invoked by uid 500); 17 Nov 2013 22:29:51 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 75692 invoked by uid 500); 17 Nov 2013 22:29:51 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 75683 invoked by uid 99); 17 Nov 2013 22:29:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Nov 2013 22:29:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A10F31C0154; Sun, 17 Nov 2013 22:29:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0411204528242641570==" MIME-Version: 1.0 Subject: Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null From: "Yichi Lu" To: "Yichi Lu" , "cloudstack" Date: Sun, 17 Nov 2013 22:29:47 -0000 Message-ID: <20131117222947.27675.98373@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yichi Lu" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15633/ X-Sender: "Yichi Lu" Reply-To: "Yichi Lu" X-ReviewRequest-Repository: cloudstack-git --===============0411204528242641570== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15633/ ----------------------------------------------------------- Review request for cloudstack. Bugs: 5079 https://issues.apache.org/jira/browse/5079 Repository: cloudstack-git Description ------- CLOUDSTACK-5079. When using api call, listConfigurations, and specifying clusterid, some keys may not have values. this causes a null pointer to be returned. Add guard against null pointer in server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope(). If a null pointer is returned from framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(), set value to 'NULL'. Diffs ----- server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada Diff: https://reviews.apache.org/r/15633/diff/ Testing ------- tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, &listConfigurations&zoneid=xxx, &listConfigurations&category=Advanced Thanks, Yichi Lu --===============0411204528242641570==--