Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D189A10C9A for ; Fri, 8 Nov 2013 07:07:42 +0000 (UTC) Received: (qmail 78166 invoked by uid 500); 8 Nov 2013 07:07:42 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 78132 invoked by uid 500); 8 Nov 2013 07:07:42 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 78124 invoked by uid 99); 8 Nov 2013 07:07:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2013 07:07:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D9FB71D35DD; Fri, 8 Nov 2013 07:07:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5104742635173652492==" MIME-Version: 1.0 Subject: Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention From: "SrikanteswaraRao Talluri" To: "SrikanteswaraRao Talluri" Cc: "Santhosh Edukulla" , "cloudstack" Date: Fri, 08 Nov 2013 07:07:38 -0000 Message-ID: <20131108070738.30021.78853@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "SrikanteswaraRao Talluri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15341/ X-Sender: "SrikanteswaraRao Talluri" References: <20131108070125.30021.66953@reviews.apache.org> In-Reply-To: <20131108070125.30021.66953@reviews.apache.org> Reply-To: "SrikanteswaraRao Talluri" --===============5104742635173652492== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28506 ----------------------------------------------------------- i can't see the diff - SrikanteswaraRao Talluri On Nov. 8, 2013, 7:01 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15341/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 7:01 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5099 > https://issues.apache.org/jira/browse/CLOUDSTACK-5099 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation > 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it. > 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/15341/diff/ > > > Testing > ------- > > > Thanks, > > Santhosh Edukulla > > --===============5104742635173652492==--