Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============5169142086568379005=="
MIME-Version: 1.0
Subject: Re: Review Request 14023: NetworkManager Exception Fix Due to call to
 getDhcpServiceProvider()
From: "Amogh Vasekar" <amogh.vasekar@citrix.com>
To: "Soheil Eizadi" <seizadi@infoblox.com>,
 "Amogh Vasekar" <amogh.vasekar@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 08 Nov 2013 02:06:55 -0000
Message-ID: <20131108020655.30022.44691@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Amogh Vasekar" <noreply@reviews.apache.org>
References: <20130906222716.24330.568@reviews.apache.org>
In-Reply-To: <20130906222716.24330.568@reviews.apache.org>
Reply-To: "Amogh Vasekar" <amogh.vasekar@citrix.com>

--===============5169142086568379005==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14023/#review28485
-----------------------------------------------------------


Reminder - 
Hi,
This review has been pending for long. Please update to "submitted" if this has already been committed.
Thanks

- Amogh Vasekar


On Sept. 6, 2013, 10:26 p.m., Soheil Eizadi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14023/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 10:26 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I ran the master branch with my NetworkElement integrated which provides DHCP service. In my use case I was able to create a VM but when I deleted it there was an exception in the NetworkManager when it called:
> 
> isDhcpAccrossMultipleSubnetsSupported() >> getDhcpServiceProvider()
> 
> 
> My DHCP Provider is a NetworkElement but does not implement the DhcpServiceProvider interface.
> 
> 
>    public DhcpServiceProvider getDhcpServiceProvider(Network network) {
> 
>         String DhcpProvider = _ntwkSrvcDao.getProviderForServiceInNetwork(network.getId(), Service.Dhcp);
> 
> 
>         if (DhcpProvider == null) {
> 
>             s_logger.debug("Network " + network + " doesn't support service " + Service.Dhcp.getName());
> 
>             return null;
> 
>         }
> 
> 
>         return (DhcpServiceProvider)_networkModel.getElementImplementingProvider(DhcpProvider);
> 
> 
>     }
> 
> 
> There is a check in the NetworkManager in the Prepare stage but a similar check is missing in Release stage.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java ae27554 
> 
> Diff: https://reviews.apache.org/r/14023/diff/
> 
> 
> Testing
> -------
> 
> I verified in my environment where due to VM expunge failing to NetworkManager exception the system would retry on a timer. After the fix the VM was removed from the system after the first retry.
> 
> 
> Thanks,
> 
> Soheil Eizadi
> 
>


--===============5169142086568379005==--