Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0744A10D72 for ; Thu, 7 Nov 2013 22:28:48 +0000 (UTC) Received: (qmail 88891 invoked by uid 500); 7 Nov 2013 22:28:47 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 88863 invoked by uid 500); 7 Nov 2013 22:28:47 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 88852 invoked by uid 99); 7 Nov 2013 22:28:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 22:28:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E31991D3952; Thu, 7 Nov 2013 22:28:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8885012753972114155==" MIME-Version: 1.0 Subject: Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*) From: "edison su" To: "edison su" Cc: "Chris Suich" , "cloudstack" Date: Thu, 07 Nov 2013 22:28:43 -0000 Message-ID: <20131107222843.30021.29192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15313/ X-Sender: "edison su" References: <20131107210025.30022.30089@reviews.apache.org> In-Reply-To: <20131107210025.30022.30089@reviews.apache.org> Reply-To: "edison su" --===============8885012753972114155== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/#review28457 ----------------------------------------------------------- Ship it! Ship It! - edison su On Nov. 7, 2013, 9 p.m., Chris Suich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15313/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 9 p.m.) > > > Review request for cloudstack and edison su. > > > Repository: cloudstack-git > > > Description > ------- > > VMSnapshotDetailsDao/Impl/VO were not using the ResourceDetails/Dao/Base pattern which caused issues with adding details and did not give access to useful methods like the detail getters/deleters. > > > Diffs > ----- > > engine/schema/src/com/cloud/vm/snapshot/VMSnapshotDetailsVO.java 934dd92 > engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDao.java e84178c > engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDaoImpl.java b528b39 > engine/storage/integration-test/test/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java fc52f89 > > Diff: https://reviews.apache.org/r/15313/diff/ > > > Testing > ------- > > This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of. > > > Thanks, > > Chris Suich > > --===============8885012753972114155==--