Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 253FA10879 for ; Thu, 7 Nov 2013 21:00:19 +0000 (UTC) Received: (qmail 23707 invoked by uid 500); 7 Nov 2013 21:00:18 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 23665 invoked by uid 500); 7 Nov 2013 21:00:18 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 23655 invoked by uid 99); 7 Nov 2013 21:00:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 21:00:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 839EF1D3939; Thu, 7 Nov 2013 21:00:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0736392690418055265==" MIME-Version: 1.0 Subject: Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots From: "Chris Suich" To: "edison su" Cc: "Chris Suich" , "cloudstack" Date: Thu, 07 Nov 2013 21:00:15 -0000 Message-ID: <20131107210015.30022.66806@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Suich" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15309/ X-Sender: "Chris Suich" References: <20131107152821.30021.90937@reviews.apache.org> In-Reply-To: <20131107152821.30021.90937@reviews.apache.org> Reply-To: "Chris Suich" --===============0736392690418055265== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ ----------------------------------------------------------- (Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. Repository: cloudstack-git Description ------- A bug was introduced in a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 which does not allow VMWare VM snapshots to be deleted. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 In refactoring, volumeTo.getPoolUuid() was supposed to be changed to store.getUuid() but was actually changed to volumeTo.getUuid(). Diffs ----- plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 0e2423e Diff: https://reviews.apache.org/r/15309/diff/ Testing (updated) ------- This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of. Thanks, Chris Suich --===============0736392690418055265==--