Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============8321516753157362344=="
MIME-Version: 1.0
Subject: Re: Review Request 8294: Store NetworkServiceProvider connectivity
 service
 configuration in database.
From: "Amogh Vasekar" <amogh.vasekar@citrix.com>
To: "Hiroaki Kawai" <kawai@stratosphere.co.jp>,
 "Animesh Chaturvedi" <Animesh.Chaturvedi@citrix.com>,
 "Hugo Trippaers" <htrippaers@schubergphilis.com>,
 "Amogh Vasekar" <amogh.vasekar@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 07 Nov 2013 19:10:29 -0000
Message-ID: <20131107191029.30021.45850@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Amogh Vasekar" <noreply@reviews.apache.org>
References: <20130129094354.24967.65626@reviews.apache.org>
In-Reply-To: <20130129094354.24967.65626@reviews.apache.org>
Reply-To: "Amogh Vasekar" <amogh.vasekar@citrix.com>

--===============8321516753157362344==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Jan. 29, 2013, 9:43 a.m., Hugo Trippaers wrote:
> > The change looks good. Could you update the patch to the latest state of master?
> 
> Animesh Chaturvedi wrote:
>     Hiroaki can you update the patch to latetst master.
> 
> Animesh Chaturvedi wrote:
>     Any updates Hiroaki?

Reminder-
Hi,
The review has been pending for long. Hugo / Hiroaki - can you please update if this is still necessary, or needs to be discarded?
Thanks


- Amogh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8294/#review15794
-----------------------------------------------------------


On Nov. 30, 2012, 12:17 p.m., Hiroaki Kawai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8294/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 12:17 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> There are 13 services defined in com.cloud.network.Network.Service , but db schema has 12 services with connecitivity missing in `cloud`.`physical_network_service_providers` . This patch will fix this. In the cloudstack api response, we'll see Connectivity service is enabled in NiciraNvp network service provider servicelist like this:
> 
> {
>     "listnetworkserviceprovidersresponse": {
>         "count": 1,
>         "networkserviceprovider": [
>             {
>                 "physicalnetworkid": "80bf64a1-c5ca-4eb1-810e-76917a317d59",
>                 "servicelist": [
>                     "Connectivity"
>                 ],
>                 "name": "NiciraNvp",
>                 "destinationphysicalnetworkid": "0",
>                 "state": "Disabled",
>                 "id": "efb45f75-9fd7-43aa-9937-b5c871971c00"
>             }
>         ]
>     }
> }
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311 
>   packaging/centos63/package.sh 83c0e5e 
>   server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java 12b08af 
>   server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39 
>   setup/db/create-schema.sql fff084e 
>   setup/db/db/schema-40to41.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8294/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>


--===============8321516753157362344==--