Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D72FD10A7A for ; Thu, 7 Nov 2013 07:17:55 +0000 (UTC) Received: (qmail 87851 invoked by uid 500); 7 Nov 2013 07:17:54 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 87812 invoked by uid 500); 7 Nov 2013 07:17:54 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 87801 invoked by uid 99); 7 Nov 2013 07:17:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 07:17:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C211F1D2F25; Thu, 7 Nov 2013 07:17:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6962324103819273929==" MIME-Version: 1.0 Subject: Re: Review Request 15173: Dynamic compute offering. From: "Koushik Das" To: "Kishan Kavala" , "Koushik Das" Cc: "bharat kumar" , "cloudstack" Date: Thu, 07 Nov 2013 07:17:51 -0000 Message-ID: <20131107071751.30022.92725@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Koushik Das" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15173/ X-Sender: "Koushik Das" References: <20131107071723.30022.79460@reviews.apache.org> In-Reply-To: <20131107071723.30022.79460@reviews.apache.org> Reply-To: "Koushik Das" --===============6962324103819273929== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 7, 2013, 7:17 a.m., Koushik Das wrote: > > Ship It! commit 7095ea2b5e497620c8c879517565046e3b46e493 - Koushik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/#review28355 ----------------------------------------------------------- On Nov. 7, 2013, 6:24 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15173/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 6:24 a.m.) > > > Review request for cloudstack, Kishan Kavala and Koushik Das. > > > Bugs: CLOUDSTACK-4738 > https://issues.apache.org/jira/browse/CLOUDSTACK-4738 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-4738 > Dynamic compute Offering. > > Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. > > > Diffs > ----- > > api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e > api/src/com/cloud/vm/UserVmService.java 0b142e8 > api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e > api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 > engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 > engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 > engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 > engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 > engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION > engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 > engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 > engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION > engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION > engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 > engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 > engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d > plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c > plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 > server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 > server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e > server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b > server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 > server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f > server/test/com/cloud/vm/UserVmManagerTest.java df676d3 > server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 > server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION > server/test/resources/createNetworkOffering.xml 9d684ba > setup/db/db/schema-421to430.sql 980650d > > Diff: https://reviews.apache.org/r/15173/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > > --===============6962324103819273929==--