cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Huang <Alex.Hu...@citrix.com>
Subject RE: [MERGE] Reformat of the source code....
Date Thu, 21 Nov 2013 16:16:31 GMT
Hi All,

I just pushed this change.  It's a big change but mostly harmless as it's mostly white space.
 I'm unable to turn on checkstyle on the whole project as there's still about 1000 strings
that are longer than the 180 column limit.  Will try to work through those before I leave
CCC tomorrow.  Thanks to Hugo and Daan for the checkstyle plugin that's already in the nvp
plugin.  I just re-used that for the checkstyle checks.

The changes include the following:
- Removal of unused imports
- Reorganized the imports
- Expanded '*' imports
- Changed tabs to space
- Removed trailing spaces
- Changed dos line endings to unix line endings (although I don't think any files actually
had that problem.)
- Rejoined code that were broken up due to the 80 column limit.
- Broken up lines longer than the 180 column limit.

--Alex

> -----Original Message-----
> From: Hugo Trippaers [mailto:trippie@gmail.com]
> Sent: Wednesday, November 20, 2013 2:39 PM
> To: dev@cloudstack.apache.org
> Cc: dev@cloudstack.apache.org
> Subject: Re: [MERGE] Reformat of the source code....
> 
> +1!
> 
> Sent from my iPhone
> 
> > On 20 nov. 2013, at 16:15, Alex Huang <Alex.Huang@citrix.com> wrote:
> >
> > Taking advantage of the CCC happening and 4.3 just being branched, I did a
> reformat of the entire source base.  It converts all tabs to spaces and rejoin
> lines that were split due to the 80 column limit.  I also added checkstyle to
> maven build.  There may be things missing here and there but overall should
> reduce the number of lines in our checkins.
> >
> > It created a massive amount of change of course but it all compiles and
> starts up.  Any concerns about met checking this in to master?  I'll wait 24
> hours for this merge request since we've talked about this before.
> >
> > --Alex

Mime
View raw message