cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request 15832: enable custom offering support for scalevm
Date Tue, 26 Nov 2013 18:27:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/#review29445
-----------------------------------------------------------



api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
<https://reviews.apache.org/r/15832/#comment56657>

    All this is boilerplate code. Have an abstract class and make all these classes extend
this abstract class. There are some examples to get an idea for doing this.



api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java
<https://reviews.apache.org/r/15832/#comment56658>

    it should be name. Also better to give example how to specify them



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56659>

    check for !(cpuNumber == null && cpuSpeed == null && memory == null)
    
    



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56661>

    I would suggest writing a util function for adding and removing these details. I think
it can be used while deploying vm as well.



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56663>

    can you please break it down ? or write comments please 



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56662>

    boiler plate code.


- Nitin Mehta


On Nov. 26, 2013, 11:38 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15832/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 11:38 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5161
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5161
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> enable scaling of a vm using custom offering
> CLOUDSTACK-5161
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java a7c864d

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java 1357a7d

>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 7ec739e 
>   engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
>   engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
>   engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
>   server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
>   server/src/com/cloud/vm/UserVmManager.java b7b4bd5 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
>   server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 
> 
> Diff: https://reviews.apache.org/r/15832/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message