cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Re: Review Request 15840: CLOUDSTACK-5206: Ability to control the external id of first class objects
Date Tue, 26 Nov 2013 18:16:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15840/#review29448
-----------------------------------------------------------


It looks like you commented out a version check in VirtualNetworkApplianceManagerImpl.java.
Was that intentional?

- Chris Suich


On Nov. 25, 2013, 6:55 p.m., Nitin Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15840/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 6:55 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5206
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5206
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5206: Ability to control the external id of first
>  class objects. Putting in the generic methods and trying it
>  for objects like vm, volume. This is the first cut
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/VolumeApiService.java 47afa10 
>   api/src/com/cloud/vm/UserVmService.java 444c47a 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
>   api/src/org/apache/cloudstack/api/BaseAsyncCreateCustomIdCmd.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java fbb785f 
>   api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java eb4ac88

>   api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java f12cef8

>   engine/schema/src/com/cloud/vm/dao/UserVmDao.java 606d424 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 43bdef1 
>   server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml 2a080f9

>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 4bbc872

>   server/src/com/cloud/storage/VolumeApiServiceImpl.java c693527 
>   server/src/com/cloud/uuididentity/UUIDManager.java PRE-CREATION 
>   server/src/com/cloud/uuididentity/UUIDManagerImpl.java PRE-CREATION 
>   server/src/com/cloud/vm/UserVmManager.java b7b4bd5 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
> 
> Diff: https://reviews.apache.org/r/15840/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Nitin Mehta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message