cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.
Date Tue, 26 Nov 2013 07:25:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/#review29424
-----------------------------------------------------------



awsapi/src/com/cloud/bridge/service/EC2RestServlet.java
<https://reviews.apache.org/r/15647/#comment56648>

    you don't seem to be using ec2PropFile for anything here?


- Hugo Trippaers


On Nov. 25, 2013, 3:15 p.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15647/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 3:15 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing coverity issues related to resource leak on FileInputStream being created anonymously.
> 
> This patch fixed the following Coverity issues:
> 
> cv_1116497
> cv_1116681
> cv_1116694
> cv_1116567
> cv_1116495
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java deb886f 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
>   framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 0d28e09

> 
> Diff: https://reviews.apache.org/r/15647/diff/
> 
> 
> Testing
> -------
> 
> A build full build was executed on top of the branch created for these changes. After
committed and patched, the a brand new branch was created from Master and patched with this
patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message