cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 15668: CLOUDSTACK-5201: Corrected code related to schedule of recurring snapshot policy
Date Tue, 19 Nov 2013 10:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15668/
-----------------------------------------------------------

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-5201
    https://issues.apache.org/jira/browse/CLOUDSTACK-5201


Repository: cloudstack-git


Description
-------

The test case was failing while getting snapshots' list because minutes were passed in the
schedule of snapshot policy when the intervalType is "Hourly". Passes hours and changed wait
time accordingly to get the snapshots list.


Diffs
-----

  test/integration/component/test_base_image_updation.py b70bea5 

Diff: https://reviews.apache.org/r/15668/diff/


Testing
-------

Tested locally on KVM advanced. No Xen advanced up right now.

Log:
test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate) ...
==> client.log <==
2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate)
- Creating recurring snapshot policy fo
r root disk on vm created with IsVolatile=True
2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate)
- Snapshot Policy - Type : HOURLY Sched
uled Hours : 1
2013-11-18 20:25:06,959 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate)
- Sleeping for 70 minutes till the volu
me is snapshoted
2013-11-18 21:35:57,329 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate)
- Checking whether root disk of VM with
 isVolatile=True was destroyed
2013-11-18 21:35:57,398 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation_fixed.TestBaseImageUpdate)
- Checking whether snapshot rule for VM
 with isVolatile=True was destroyed                    Here we are passing root disk id of
vm before reboot which does not exist hence                   listing
 should fail

==> result.log <==
ok

----------------------------------------------------------------------
Ran 4 tests in 4507.963s

OK (skipped=3)


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message