cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions
Date Mon, 18 Nov 2013 18:30:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15418/#review29058
-----------------------------------------------------------

Ship it!


Ship It!

- daan Hoogland


On Nov. 18, 2013, 11:31 a.m., Antonio Fornie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15418/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 11:31 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixes about: Code quality, checkstyle and cloudstack conventions. Tabs replaced by 4
spaces, proper instance variable names, removing trailing spaces...
> 
> 
> Diffs
> -----
> 
>   parents/checkstyle/src/main/resources/tooling/checkstyle.xml 83493d6 
>   plugins/network-elements/nicira-nvp/pom.xml 9341c93 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterAnswer.java
94931a0 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
16ef2c4 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterAnswer.java
09a3e7e 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
c08f540 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterAnswer.java
caab316 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
5f79ffc 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalRouterAnswer.java
72a275b 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalRouterCommand.java
1f3f24e 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalSwitchAnswer.java
753edec 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalSwitchCommand.java
b2a5aaf 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalSwitchPortAnswer.java
8fa7927 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/CreateLogicalSwitchPortCommand.java
fe3f683 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalRouterAnswer.java
db07547 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalRouterCommand.java
96e2cb9 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalSwitchAnswer.java
e9cfbc4 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalSwitchCommand.java
25aa339 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalSwitchPortAnswer.java
f779677 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/DeleteLogicalSwitchPortCommand.java
e91a032 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/FindLogicalSwitchPortAnswer.java
edc0c5f 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/FindLogicalSwitchPortCommand.java
b737c50 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/UpdateLogicalSwitchPortAnswer.java
f4c4130 
>   plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/UpdateLogicalSwitchPortCommand.java
1b8b590 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java
937b665 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/DeleteNiciraNvpDeviceCmd.java
6eb6764 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDeviceNetworksCmd.java
53203a7 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDevicesCmd.java
3e02e19 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/response/NiciraNvpDeviceResponse.java
d6085e2 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpDeviceVO.java 3832123

>   plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpNicMappingVO.java
d9dbb02 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpRouterMappingVO.java
1e2a831 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpDaoImpl.java
5e07246 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpNicMappingDao.java
f693dcb 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpNicMappingDaoImpl.java
1a0fcd1 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpRouterMappingDaoImpl.java
dc41f57 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
3e9e16a 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java
7057915 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/ControlClusterStatus.java
2914d35 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/DestinationNatRule.java
d149c4b 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/L3GatewayAttachment.java
96d1991 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterConfig.java
088cefc 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterPort.java
112825d 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java
f022ff7 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java
aaf5494 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Match.java e437344

>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NatRule.java f33f249

>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
ea69a09 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApiException.java
db34a15 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpList.java
9d78e84 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpTag.java
a5dd3bd 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/PatchAttachment.java
137f071 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/RouterNextHop.java
a204e55 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplictRoutingConfig.java
1228deb 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SourceNatRule.java
910f830 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/TransportZoneBinding.java
9c5f44d 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java
3a0b5f3 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
3ab5f2b 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/element/NiciraNvpElementTest.java
9202241 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
42e436f 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java
1467d47 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraTagTest.java
fd13e07 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java
78465e4 
> 
> Diff: https://reviews.apache.org/r/15418/diff/
> 
> 
> Testing
> -------
> 
> Maven build lifecycle running without any problems, including new checkstyle goals that
wouldn't without these fixes
> 
> 
> Thanks,
> 
> Antonio Fornie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message