cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yichi Lu" <yichi...@sungard.com>
Subject Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null
Date Sun, 17 Nov 2013 22:29:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15633/
-----------------------------------------------------------

Review request for cloudstack.


Bugs: 5079
    https://issues.apache.org/jira/browse/5079


Repository: cloudstack-git


Description
-------

CLOUDSTACK-5079. When using api call, listConfigurations, and specifying clusterid, some keys
may not have values. this causes a null pointer to be returned.
Add guard against null pointer in server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
If a null pointer is returned from framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
set value to 'NULL'.


Diffs
-----

  server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada 

Diff: https://reviews.apache.org/r/15633/diff/


Testing
-------

tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, &listConfigurations&zoneid=xxx,
 &listConfigurations&category=Advanced


Thanks,

Yichi Lu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message