cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request 15489: Adding protocol parameter to loadbalancer response
Date Fri, 15 Nov 2013 13:53:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15489/#review28968
-----------------------------------------------------------


Syed I dont think you added 'protocol' to createLoadBalancerRule. There should not be 'protocol'
in the LoadBalancerContainer?

- Murali Reddy


On Nov. 13, 2013, 6:08 p.m., Syed Ahmed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15489/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 6:08 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Murali Reddy.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding protocol parameter to Loadbalancer Response
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/rules/LoadBalancer.java e6dadca 
>   api/src/com/cloud/network/rules/LoadBalancerContainer.java 9d5ea59 
>   api/src/org/apache/cloudstack/api/response/LoadBalancerResponse.java 0f18097 
>   engine/schema/src/org/apache/cloudstack/lb/ApplicationLoadBalancerRuleVO.java 37a747e

>   server/src/com/cloud/api/ApiResponseHelper.java 903c485 
> 
> Diff: https://reviews.apache.org/r/15489/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Syed Ahmed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message