cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test cases failed in master
Date Thu, 14 Nov 2013 08:57:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/#review28862
-----------------------------------------------------------



api/src/com/cloud/deploy/DeploymentPlanner.java
<https://reviews.apache.org/r/15507/#comment55923>

    Is there any other changes in this file? If not remove it.



framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
<https://reviews.apache.org/r/15507/#comment55924>

    this is not required


- Koushik Das


On Nov. 14, 2013, 7:36 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15507/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 7:36 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4835
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5163
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4835: Update global configuration test cases failed in master 
> Changes made in update/list configuration API to use ConfigDepot
> 
> CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
> 
> CLOUDSTACK-5163: missing parameters in configuration table
> pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
> cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267 
>   api/src/com/cloud/deploy/DeploymentPlanner.java 88cfc74 
>   framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb

>   framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
254e6d2 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc 
>   server/src/com/cloud/configuration/Config.java bc805b7 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a

>   server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7

> 
> Diff: https://reviews.apache.org/r/15507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message