cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention
Date Fri, 08 Nov 2013 07:16:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
-----------------------------------------------------------

(Updated Nov. 8, 2013, 7:16 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
-------

Added missing patch file


Bugs: CLOUDSTACK-5099
    https://issues.apache.org/jira/browse/CLOUDSTACK-5099


Repository: cloudstack-git


Description
-------

1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here its not. Changed
it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as
well remote


Diffs
-----


Diff: https://reviews.apache.org/r/15341/diff/


Testing
-------


File Attachments (updated)
----------------

patch file
  https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
patchfile
  https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch


Thanks,

Santhosh Edukulla


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message