cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots
Date Thu, 07 Nov 2013 21:00:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15309/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 9 p.m.)


Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
-------

A bug was introduced in a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 which does not allow VMWare
VM snapshots to be deleted.

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a6ce66e55a65eb0fbae9ead92de6ceac7a87c531

In refactoring, volumeTo.getPoolUuid() was supposed to be changed to store.getUuid() but was
actually changed to volumeTo.getUuid().


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
0e2423e 

Diff: https://reviews.apache.org/r/15309/diff/


Testing (updated)
-------

This has been tested locally with a custom plugin. However, the changes are not used by the
existing CloudStack codebase and should not impact any existing workflows or use cases. They
are simply for plugins to take advantage of.


Thanks,

Chris Suich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message