cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amogh Vasekar" <amogh.vase...@citrix.com>
Subject Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes
Date Thu, 07 Nov 2013 19:16:16 GMT


> On Aug. 1, 2013, 8:31 a.m., daan Hoogland wrote:
> > I think you need to rework this. Jenkins can't apply your patch and build it.

Reminder-
Hi,
The review has been pending for long. Please update the patch since the build fails.
Thanks


- Amogh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12185/#review24427
-----------------------------------------------------------


On June 29, 2013, 2:34 a.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12185/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 2:34 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> code relies on classes in backport-util-concurrent, when these classes are now available
in the jdk supported by cloudstack.
> 
> Just switch the imports to the built in classes.
> 
> 
> Diffs
> -----
> 
>   api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 90759fe 
>   api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 
>   engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 
>   engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
b92f92f 
>   engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
362f7a6 
>   plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java
d46048e 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
0e4f8fd 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 
>   server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d 
>   server/src/com/cloud/server/ManagementServerImpl.java 40bc437 
>   tools/whisker/descriptor-for-packaging.xml 66099ae 
>   utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 
>   utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 
>   utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java cf5ffde 
> 
> Diff: https://reviews.apache.org/r/12185/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message