cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)
Date Thu, 07 Nov 2013 15:36:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15313/
-----------------------------------------------------------

Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
-------

VMSnapshotDetailsDao/Impl/VO were not using the ResourceDetails/Dao/Base pattern which caused
issues with adding details and did not give access to useful methods like the detail getters/deleters.


Diffs
-----

  engine/schema/src/com/cloud/vm/snapshot/VMSnapshotDetailsVO.java 934dd92 
  engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDao.java e84178c 
  engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDaoImpl.java b528b39 
  engine/storage/integration-test/test/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java fc52f89


Diff: https://reviews.apache.org/r/15313/diff/


Testing
-------


Thanks,

Chris Suich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message