cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request 15296: CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR
Date Thu, 07 Nov 2013 04:56:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15296/#review28353
-----------------------------------------------------------

Ship it!


Ship It!

- Marcus Sorensen


On Nov. 7, 2013, 1:11 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15296/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 1:11 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Marcus Sorensen, Hugo Trippaers, and Toshiaki
Hatano.
> 
> 
> Bugs: CLOUDSTACK-5067
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5067
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is a patch to fix the bug "CLOUDSTACK-5067 Bugfix: two NICs connected to Public
network exist in VR".
> 
> It seems it is caused by wrong handling of IpAssocCommand.
> 
> IpAssocCommand is processed inappropriately in the method "LibvirtComputingResource#execute(IpAssocCommand)".
> 
> It hotplugs unnecessary vNIC by mistake.
> https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2049
> 
> It is caused by isolation method notation mismatch in this line.
> https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2047
> 
> It expects isolation method is expressed in broadcast uri style like "vlan://1234", "vlan://untagged",
but "untagged" is passed.
> https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2033
> 
> FYI: Notation change is conducted in this commit.
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=74f02c0c639d125f435b3b3f278fe3985f09c7ca;hp=203587a06f63f23d487ae65dcf5c397cd2702166;hb=2614b00c;hpb=62b0ad03c871c7100433b39593a82d393879124e
> 
> Further, current code cannot retrieve VNI(VXLAN ID) from bridge name. This patch extends
getVlanIdFromBridge to getBroadcastUriFromBridge to support vxlan.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
e3f60f2 
> 
> Diff: https://reviews.apache.org/r/15296/diff/
> 
> 
> Testing
> -------
> 
> I deployed VR, and confirmed it has one NIC connected to Public network.
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message