cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 15175: Added a verifyElementInList utility function
Date Mon, 04 Nov 2013 08:28:48 GMT


> On Nov. 4, 2013, 8:21 a.m., Prasanna Santhanam wrote:
> > Easier to do if a in [1,2,3]: , no?

1. Purpose is to check whether the input is list and whether it is empty as well.

2. If it is not a list, then a in None will lead to exception.

3. Purpose is also to provide a generic api to check the element presence at a given position
as well. a in [1,2,3] will check, if  a is in the list but which position we are expecting
this element to be? so position is also required, generally we are verifying the first element
so we keyworded the pos=0 to make it easier.

4. Provide custom error codes and messages for log and further processing.

5. This will benefit the case to remove multiple asserts in to one single line of code with
new utility and make it cleaner to maintain at one place.

self.assertEqual(
            isinstance(list_network_offerings_response, list),
            True,
            "listNetworkOfferings returned invalid object in response."
            )

self.assertNotEqual(
            len(list_network_offerings_response),
            0,
            "listNetworkOfferings returned empty list."
)

self.assertEqual(
            list_network_offerings_response[0].state,
            "Enabled",
            "The network offering state should get updated to Enabled."
)


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15175/#review28085
-----------------------------------------------------------


On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15175/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 7:44 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The purpose is to verify a given element in list at a given position with few error checks
like list type,empty list and position
> Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple
asserts
>  
> Earlier, there was a list validity function, this is on top of that.
>    
> Need to go to both master and 4.2
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/codes.py bd01ad3 
>   tools/marvin/marvin/integration/lib/utils.py b6e38ec 
> 
> Diff: https://reviews.apache.org/r/15175/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> >>> from utils import verifyElementInList
> >>> a=[1,2,3]
> >>> verifyElementInList(a,2)
> [0, 'ELEMENT NOT FOUND IN THE INPUT']
> >>> verifyElementInList(a,1)
> [1, None]
> >>> verifyElementInList(a,3)
> [0, 'ELEMENT NOT FOUND IN THE INPUT']
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message