cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
Date Sun, 03 Nov 2013 19:45:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/#review28081
-----------------------------------------------------------

Ship it!


can you test and submit for master as well?

d6420cd91ebb493e8b9d4220e95b7a3250272db3

- daan Hoogland


On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15181/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 3:52 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5023
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5023
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are
enabled
> 
> Added logic so that a correct zoneID is passed when generating usage events while deleting
port forwarding rules:
> - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab
zone id and pass to publishUsageEvent
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08 
> 
> Diff: https://reviews.apache.org/r/15181/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.2.0 tag
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message