cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Review Request 15175: Added a verifyElementInList utility function
Date Fri, 01 Nov 2013 07:44:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15175/
-----------------------------------------------------------

Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

The purpose is to verify a given element in list at a given position with few error checks
like list type,empty list and position
Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple
asserts
 
Earlier, there was a list validity function, this is on top of that.
   
Need to go to both master and 4.2


Diffs
-----

  tools/marvin/marvin/codes.py bd01ad3 
  tools/marvin/marvin/integration/lib/utils.py b6e38ec 

Diff: https://reviews.apache.org/r/15175/diff/


Testing
-------

Tested.

>>> from utils import verifyElementInList
>>> a=[1,2,3]
>>> verifyElementInList(a,2)
[0, 'ELEMENT NOT FOUND IN THE INPUT']
>>> verifyElementInList(a,1)
[1, None]
>>> verifyElementInList(a,3)
[0, 'ELEMENT NOT FOUND IN THE INPUT']


Thanks,

Santhosh Edukulla


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message