Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B85110355 for ; Thu, 17 Oct 2013 22:06:12 +0000 (UTC) Received: (qmail 91585 invoked by uid 500); 17 Oct 2013 22:06:11 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 91550 invoked by uid 500); 17 Oct 2013 22:06:11 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 91542 invoked by uid 99); 17 Oct 2013 22:06:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2013 22:06:11 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of darren.s.shepherd@gmail.com designates 209.85.215.50 as permitted sender) Received: from [209.85.215.50] (HELO mail-la0-f50.google.com) (209.85.215.50) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2013 22:06:05 +0000 Received: by mail-la0-f50.google.com with SMTP id gx14so22453lab.9 for ; Thu, 17 Oct 2013 15:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=LIn98Js9huu4ZxsD+8EjR5EzOYJFsa/JpkXipwKwkEY=; b=vtvnylI1WVGdMdf6By72IbeIhvD7gtfrXG2yXpsfc8UX7E3gAIOV4cylQ8dcD6s9sn tK/VFWRMZacMBVpPZIMDKkTXGrwUjjseIFpxc5i1cE3kRN8qBFO5Y7QI6lHs/kRRSVp8 JnOqH2Ul1UlJSDORsmBLdXw1agIOHH/hW7dSd7K1ZjuQbz6RFdkd21EkJg7myK3UvknV vbwYnquJRpEXSC+UQgm4CfaB2rdS+oC5qiaMIozRpcaGCBdiargY7RFi3wEc6T4YMJBS SsWeYXqk7onvq6goZOAwpu1Dqw41GofWaa9XqFuywoGo8Rzh6AFNZ5/1U9M5CFgjpzsP agQQ== MIME-Version: 1.0 X-Received: by 10.112.145.105 with SMTP id st9mr96030lbb.46.1382047545116; Thu, 17 Oct 2013 15:05:45 -0700 (PDT) Received: by 10.112.28.19 with HTTP; Thu, 17 Oct 2013 15:05:45 -0700 (PDT) In-Reply-To: <2473D6CF-0FB9-4E1C-A9CA-C87691874A3C@gmail.com> References: <2AD0D256-8418-4E6E-B5DE-FA456D18EC06@GMAIL.com> <84B0AECD-80EE-480E-AAA6-E3E769430B0C@GMAIL.com> <52602889.2080801@gmail.com> <2473D6CF-0FB9-4E1C-A9CA-C87691874A3C@gmail.com> Date: Thu, 17 Oct 2013 15:05:45 -0700 Message-ID: Subject: Re: [MERGE] txn-refactor From: Darren Shepherd To: "dev@cloudstack.apache.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Oct 17, 2013 at 12:59 PM, Hugo Trippaers wrote: > Maybe just mark start() as deprecated then. Would at least put a marker f= or anybody writing new code that they should think again about using it. Good idea. > > A unit test would be really nice to have for this piece of code. Especial= ly now we know there will be changes is this area for some time to come. Th= e DB layer is at the core of CloudStack so a test is a real requirement her= e. I know there is a bunch of stuff disabled, we decided long ago to fix th= ose tests when we would touch that bit of code, and you just hit the jackpo= t ;-) > I wrote some tests, I'll commit them in a bit. > Did you have a look at the build link? The current build for your branch = appears broken. One test failure and a compile error as far as I can tell. I had no clue that build-with-branch jenkins jobs existed! That is very useful. How do I get an account to kick off jobs? I do feel stupid now looking at the build error. I had some maven projects disabled, so I forgot to update about 10 different projects. I'll fix those real quick and commit. Darren