Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AB1110216 for ; Wed, 23 Oct 2013 05:26:18 +0000 (UTC) Received: (qmail 40380 invoked by uid 500); 23 Oct 2013 05:26:15 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 40092 invoked by uid 500); 23 Oct 2013 05:26:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 40077 invoked by uid 99); 23 Oct 2013 05:26:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2013 05:26:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F227F1D3680; Wed, 23 Oct 2013 05:26:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0652873551743158428==" MIME-Version: 1.0 Subject: Review Request 14867: api call to import ldap users to the same domains in cloudstack From: "Rajani Karuturi" To: "Ian Duffy" , "Abhinandan Prateek" Cc: "Rajani Karuturi" , "cloudstack" Date: Wed, 23 Oct 2013 05:26:10 -0000 Message-ID: <20131023052610.3657.64234@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rajani Karuturi" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/14867/ X-Sender: "Rajani Karuturi" Reply-To: "Rajani Karuturi" --===============0652873551743158428== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14867/ ----------------------------------------------------------- Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Bugs: CLOUDSTACK-4866 https://issues.apache.org/jira/browse/CLOUDSTACK-4866 Repository: cloudstack-git Description ------- Added an api call to import all the ldap users to the same domains(ou's) in cloudstack TODO: 1. error handling of no domains present, nested hierarchy 2. handling the case when the api call fails for a specific user/users 3. test cases for LdapUserManager Diffs ----- api/src/com/cloud/user/DomainService.java 7c302e3 client/tomcatconf/commands.properties.in 0296de0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc server/src/com/cloud/user/DomainManagerImpl.java b885c48 server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d Diff: https://reviews.apache.org/r/14867/diff/ Testing ------- testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently) Thanks, Rajani Karuturi --===============0652873551743158428==--