Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63D8810404 for ; Tue, 22 Oct 2013 20:20:18 +0000 (UTC) Received: (qmail 52507 invoked by uid 500); 22 Oct 2013 20:20:00 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 52388 invoked by uid 500); 22 Oct 2013 20:19:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 52354 invoked by uid 99); 22 Oct 2013 20:19:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 20:19:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8DE01D3677; Tue, 22 Oct 2013 20:19:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1701887293796789347==" MIME-Version: 1.0 Subject: Review Request 14855: [Ssl Termination Support] Certificate managenemt interface From: "Syed Ahmed" To: "Darren Shepherd" , "Murali Reddy" , "Shengsheng Huang" Cc: "Syed Ahmed" , "cloudstack" Date: Tue, 22 Oct 2013 20:19:50 -0000 Message-ID: <20131022201950.3694.96720@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Syed Ahmed" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/14855/ X-Sender: "Syed Ahmed" Reply-To: "Syed Ahmed" --===============1701887293796789347== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14855/ ----------------------------------------------------------- Review request for cloudstack, Darren Shepherd, Murali Reddy, and Shengsheng Huang. Bugs: CLOUDSTACK-4821 https://issues.apache.org/jira/browse/CLOUDSTACK-4821 Repository: cloudstack-git Description ------- This is the first patch for Ssl termination support in Cloudstack. This patch is for the certificate management. Basically uploading, validation, deletion, listing for the certificates. The FS for this is at https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSL+Termination+Support . I will work on the second patch which will assign the certificates to loadbalancing rules. Diffs ----- api/src/com/cloud/network/lb/CertService.java PRE-CREATION api/src/com/cloud/network/lb/SslCert.java PRE-CREATION api/src/org/apache/cloudstack/api/ApiConstants.java c75e6a0 api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 2a3520b client/tomcatconf/nonossComponentContext.xml.in 9d1da95 engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION server/src/com/cloud/server/ManagementServerImpl.java 699f469 server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION server/test/org/apache/cloudstack/network/lb/CertServiceTest.java PRE-CREATION server/test/resources/certs/bad_format_cert.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.key PRE-CREATION server/test/resources/certs/expired_cert.crt PRE-CREATION server/test/resources/certs/non_x509_pem.crt PRE-CREATION server/test/resources/certs/root_chain.crt PRE-CREATION server/test/resources/certs/rsa_ca_signed.crt PRE-CREATION server/test/resources/certs/rsa_ca_signed.key PRE-CREATION server/test/resources/certs/rsa_ca_signed2.crt PRE-CREATION server/test/resources/certs/rsa_ca_signed2.key PRE-CREATION server/test/resources/certs/rsa_random_pkey.key PRE-CREATION server/test/resources/certs/rsa_self_signed.crt PRE-CREATION server/test/resources/certs/rsa_self_signed.key PRE-CREATION server/test/resources/certs/rsa_self_signed_with_pwd.crt PRE-CREATION server/test/resources/certs/rsa_self_signed_with_pwd.key PRE-CREATION setup/db/db/schema-421to430.sql aaebf96 Diff: https://reviews.apache.org/r/14855/diff/ Testing ------- Unittests are done and included in the review. Thanks, Syed Ahmed --===============1701887293796789347==--