Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A7B2B104ED for ; Tue, 22 Oct 2013 05:13:38 +0000 (UTC) Received: (qmail 46841 invoked by uid 500); 22 Oct 2013 05:13:31 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 46802 invoked by uid 500); 22 Oct 2013 05:13:29 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 46788 invoked by uid 99); 22 Oct 2013 05:13:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 05:13:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E171C1D3668; Tue, 22 Oct 2013 05:13:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9189312126703949206==" MIME-Version: 1.0 Subject: Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) From: "ASF Subversion and Git Services" To: "Koushik Das" Cc: "ASF Subversion and Git Services" , "Harikrishna Patnala" , "cloudstack" Date: Tue, 22 Oct 2013 05:13:23 -0000 Message-ID: <20131022051323.25434.33458@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/14305/ X-Sender: "ASF Subversion and Git Services" References: <20131021051457.25435.33252@reviews.apache.org> In-Reply-To: <20131021051457.25435.33252@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============9189312126703949206== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14305/#review27276 ----------------------------------------------------------- Commit 54e365d00b5ae504c59c025b37387b9c9d166422 in branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e365d ] CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs Signed-off-by: Koushik Das Conflicts: api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java - ASF Subversion and Git Services On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14305/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 5:14 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-4493 > https://issues.apache.org/jira/browse/CLOUDSTACK-4493 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) > Changing the response object of register and list ssh keypairs APIs > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e > api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 > > Diff: https://reviews.apache.org/r/14305/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > > --===============9189312126703949206==--