Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C55F510926 for ; Mon, 21 Oct 2013 09:29:35 +0000 (UTC) Received: (qmail 91610 invoked by uid 500); 21 Oct 2013 09:29:34 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 91577 invoked by uid 500); 21 Oct 2013 09:29:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 91554 invoked by uid 99); 21 Oct 2013 09:29:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Oct 2013 09:29:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0FDDD1D2810; Mon, 21 Oct 2013 09:29:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2040159332068568173==" MIME-Version: 1.0 Subject: Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR From: "sanjeev n" To: "SrikanteswaraRao Talluri" Cc: "sanjeev n" , "cloudstack" Date: Mon, 21 Oct 2013 09:29:30 -0000 Message-ID: <20131021092930.25435.77351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "sanjeev n" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/14737/ X-Sender: "sanjeev n" References: <20131018092713.29093.42542@reviews.apache.org> In-Reply-To: <20131018092713.29093.42542@reviews.apache.org> Reply-To: "sanjeev n" --===============2040159332068568173== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/ ----------------------------------------------------------- (Updated Oct. 21, 2013, 9:29 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Changes ------- Incorporated the review comments. Repository: cloudstack-git Description ------- Added following code in the existing test 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method 2.Added test to verify ip alias removal after destroying last vm in the cidr 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR Diffs (updated) ----- test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e Diff: https://reviews.apache.org/r/14737/diff/ Testing ------- Yes Thanks, sanjeev n --===============2040159332068568173==--