Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3097707899432384766=="
MIME-Version: 1.0
Subject: Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not
 reach
 running state
From: "sanjeev n" <sanjeev.neelarapu@citrix.com>
To: "sanjeev n" <sanjeev.neelarapu@citrix.com>,
 "venkata swamy babu  budumuru" <venkataswamybabu.budumuru@citrix.com>
Cc: "Girish Shilamkar" <girish@clogeny.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 17 Oct 2013 09:45:20 -0000
Message-ID: <20131017094520.7309.60184@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "sanjeev n" <noreply@reviews.apache.org>
References: <20131009095003.20899.66640@reviews.apache.org>
In-Reply-To: <20131009095003.20899.66640@reviews.apache.org>
Reply-To: "sanjeev n" <sanjeev.neelarapu@citrix.com>

--===============3097707899432384766==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14556/#review27113
-----------------------------------------------------------

Ship it!


Patch is good to go.

- sanjeev n


On Oct. 9, 2013, 9:50 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14556/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 9:50 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and venkata swamy babu  budumuru.
> 
> 
> Bugs: CLOUDSTACK-4766
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4766
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test use to wait for ever for the vm to attain Running state.
> Added a timeout so it does not get into infinite loop.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_reset_ssh_keypair.py ace4499 
> 
> Diff: https://reviews.apache.org/r/14556/diff/
> 
> 
> Testing
> -------
> 
> Verified that the timeout works. 
> 
> test_01_reset_keypair_normal_user (test_reset_ssh_keypair.TestResetSSHKeyUserRights)Verify API resetSSHKeyForVirtualMachine for non admin non root ... FAIL
> test_02_reset_keypair_domain_admin (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... ok
> test_03_reset_keypair_root_admin (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... ok
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... ok
> test_02_reset_ssh_key_password_enabled_template (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... ok
> test_04_reset_key_passwd_enabled_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... ok
> test_06_reset_key_passwd_enabled_vm_running (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_07_reset_keypair_invalid_params (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters … ok
> 
> ======================================================================
> FAIL: test_01_reset_keypair_normal_user (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/root/girish/test_reset_ssh_keypair.py", line 1218, in test_01_reset_keypair_normal_user
>     % (vms[0].name, self.services["timeout"]))
> AssertionError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df failed to start even after 10 minutes
> 
> ----------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


--===============3097707899432384766==--